TwinCAT/BSD for OS Version #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved the SemVer stuff to keep the upstream as simple as possible
Added addtional check for if bsd or not
|
I'd recommend a squash merge for cleaner upstream |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a very simple change in the style of the codebase to add support to display the correct OS version when the OS is TwinCAT/BSD.
I have found that the data is always of the same values:
[148, 0, 0, 0, 14, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 84, 119, 105, 110, 67, 65, 84, 47, 66, 83, 68 ...]This is ends up being:
size = 148
version = 14.0.0
platform = 0
Then the data is TwinCAT/BSD, but from the platform we know that. So I ignore the data.
Regards